terraform/settings: preserve blob_storage.managed_prefix on enterprise read#226
Draft
terraform/settings: preserve blob_storage.managed_prefix on enterprise read#226
Conversation
| dst, diagnostics := types.ObjectValue(BlobStorageSettingsObjectType().AttrTypes, map[string]attr.Value{ | ||
| "bucket_uri": types.StringPointerValue(src.BucketUri), | ||
| "managed_prefix": types.StringNull(), | ||
| "managed_prefix": types.StringPointerValue(src.ManagedPrefix), |
Contributor
There was a problem hiding this comment.
managed_prefix is set by the console's cluster config syncer. It expects to match the uuid assigned to a particular cluster, since the blob store encodes that information (separating recordings by pomerium instance).
perhaps there is a way to ignore this setting completely from the provider's state? Idk
The intention was to only allow core's local config to override this field, as a mitigation/workaround for bad syncer state or other issues
alexandreLamarre
added a commit
that referenced
this pull request
Apr 28, 2026
…der API (#227) #226 (comment) managed_prefix is managed internally by the cluster syncer, so should be omitted from the terraform provider API surface area
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The enterprise read path for
blob_storagewas dropping themanaged_prefixfield, leaving it null in state even when the API returned a value. Enterprise users who setmanaged_prefixsaw a perpetual diff on plan.The write path and the non-enterprise read path already handle the field correctly — this brings the enterprise read path in line. A regression test covers the converter.
Fixes ENG-3942.