Add suppor for symfony's 3.3 service locator by mvrhov · Pull Request #73 · pomm-project/pomm-bundle

mvrhov · 2017-04-22T11:14:16Z

This adapts model and model layer poolers to the symfony 3.3 and their service locator, and a new way to define the service to be autowireable. It also gets rid of the deprecation notices.

mvrhov · 2017-04-22T11:29:26Z

Failures are not because of my PR.

mvrhov · 2017-05-02T11:13:24Z

@sanpii This one is continuation of a previous one. It would be nice to have it 2.3

sanpii · 2017-05-02T11:21:52Z

This one is continuation of a previous one. It would be nice to have it 2.3

Sorry, the 2.3 is already in release candidate phase, it’s not possible to add new feature at this point.

chanmix51 · 2017-05-02T12:16:58Z

Is it possible to add it to the 2.4 milestone then?

sanpii · 2017-05-02T12:21:10Z

Is it possible to add it to the 2.4 milestone then?

Yes, of course, except if there is a BC break.

mvrhov · 2017-05-02T12:25:34Z

This is a bit unfortunate. As SF 3.3 will be out at the end of the month and using this bundle with 3.3 will immediately result in a deprecation warnings

sanpii · 2017-05-02T12:30:17Z

This is a bit unfortunate. As SF 3.3 will be out at the end of the month and using this bundle with 3.3 will immediately result in a deprecation warnings

It’s a good excuse to make a new release quickly 😄

lunika · 2017-06-01T09:09:59Z

This is a bit unfortunate. As SF 3.3 will be out at the end of the month and using this bundle with 3.3 will immediately result in a deprecation warnings

Which one ? I updated to SF 3.3 and I didn't have deprecation warning from PommBundle.

mvrhov · 2017-06-01T15:56:07Z

Only if you use the autowiring.

lunika · 2017-06-02T13:42:51Z

Right, the autowiring-type property is deprecated.

sanpii · 2017-06-08T12:53:12Z

sources/lib/Model/ContainerModelPooler.php

@@ -10,8 +10,8 @@
 namespace PommProject\PommBundle\Model;


I don’t undestand the goal of changes in this file. The ContainerAwareTrait already requires a ContainerInterface.

ContainerAware is not compatible with PSR container. And service locator in Sf3.3 returns PSR container interface, Previous sf version their own.

sanpii · 2017-06-08T12:54:05Z

sources/lib/Model/ContainerModelLayerPooler.php

@@ -11,8 +11,8 @@



I don’t undestand the goal of changes in this file. The ContainerAwareTrait already requires a ContainerInterface.

same as above

sanpii · 2017-06-08T12:58:52Z

sources/lib/DependencyInjection/Compiler/ModelPass.php

        $definitions = [];

+        $poolerToService = [];
+        $gteSf33 = class_exists('Symfony\Component\DependencyInjection\Compiler\ServiceLocatorTagPass');


Use more explicit variable name.

sanpii · 2017-06-08T13:00:55Z

sources/lib/DependencyInjection/Compiler/ModelPass.php

-                ->setAutowiringTypes([$old->getClass()]) //set this one as a default for autowire
            ;
+
+            if ($gteSf33) {


I think it’s a good idea to split this method into two functions to reduce complexity and length of this one.

IMO there is no need.

lunika · 2017-06-08T19:58:50Z

sources/lib/Model/ContainerModelLayerPooler.php

-use Symfony\Component\DependencyInjection\ContainerAwareInterface;
-use Symfony\Component\DependencyInjection\ContainerAwareTrait;
+use Symfony\Component\DependencyInjection\ContainerInterface;
+use Psr\Container\ContainerInterface as PsrContainer;


you should rename it in PsrContainerInterface to do like in symfony code.

lunika · 2017-06-08T20:00:32Z

sources/lib/Model/ContainerModelLayerPooler.php

+    /**
+     * @param PsrContainer|ContainerInterface $container
+     */
+    public function setContainer($container)


You can type hint with the PsrContainerInterface, The ContainerInterface extends it so you can inject both without the if block below

No I cannot. Because we need to be compatible with sf < 3.3

indeed, I didn't thought about that... sorry

mvrhov · 2017-07-26T16:33:16Z

@sanpii Can we get this merged into the master please. It's annoying to use a local fork.

mvrhov · 2017-09-26T16:53:20Z

So in two months time the sf 4.0 will be released and this PR is till not merged.
Can we please merge this after 5 months.

sanpii · 2017-10-31T12:32:35Z

I don’t understand the complexity of this PR. For me, it should be something like this:

if (version_compare(\Symfony\Component\HttpKernel\Kernel::VERSION, '3.3', '>=')) {
    $container->setAlias($class,  $id);
} else {
    $new->addAutowiringType($class);
}

mvrhov · 2017-10-31T12:50:58Z

@sanpii Isn't running this on each loop a little bit expensive? I know that this is run once but still.
I can replace the class_exists with version compare if that's what you prefer.

sanpii · 2017-10-31T13:27:52Z

Isn't running this on each loop a little bit expensive?

Yes, it’s probably a good idea.

mvrhov · 2017-10-31T14:11:45Z

Done

mvrhov · 2017-12-13T18:28:56Z

@sanpii ping. This is slowly getting annoying. I have this open for 8 moths. And it's still not merged. This bundle could have been sf4 compatible 8 moths ago.

mvrhov · 2018-01-17T18:00:42Z

@sanpii This one is rebased now and should be a part of 2.4

mvrhov · 2018-01-17T18:22:36Z

Tests seem to pass except phpcs is complaining about something but it doesn't tell about what.

stood · 2018-01-17T21:15:01Z

@mvrhov for phpcs : vendor/bin/phpcs --standard=psr2 sources

mvrhov · 2018-01-18T06:38:10Z

Fixed. Thanks

mvrhov mentioned this pull request Jun 1, 2017

Warning raised with SF 3.3 in ContainerModelLayerPooler #81

Closed

mvrhov force-pushed the modelAsServiceSf33 branch 2 times, most recently from 7868690 to edf7678 Compare June 1, 2017 07:53

sanpii requested changes Jun 8, 2017

View reviewed changes

lunika suggested changes Jun 8, 2017

View reviewed changes

mvrhov force-pushed the modelAsServiceSf33 branch from edf7678 to 9995cc2 Compare July 26, 2017 16:32

mvrhov mentioned this pull request Sep 26, 2017

Allow symfony 4 #85

Merged

mvrhov force-pushed the modelAsServiceSf33 branch from 9995cc2 to e1f308d Compare October 31, 2017 13:37

sanpii mentioned this pull request Dec 3, 2017

Support symfony4 #86

Closed

5 tasks

mvrhov force-pushed the modelAsServiceSf33 branch 2 times, most recently from f37f096 to 57b6999 Compare December 14, 2017 16:31

mvrhov force-pushed the modelAsServiceSf33 branch from 57b6999 to 45f9b1a Compare January 17, 2018 17:58

Add suppor for symfony's 3.3 service locator

5ccad45

mvrhov force-pushed the modelAsServiceSf33 branch from 45f9b1a to 5ccad45 Compare January 18, 2018 06:37

Merge branch 'master' into modelAsServiceSf33

3546511

Conversation

mvrhov commented Apr 22, 2017

Uh oh!

mvrhov commented Apr 22, 2017

Uh oh!

mvrhov commented May 2, 2017

Uh oh!

sanpii commented May 2, 2017

Uh oh!

chanmix51 commented May 2, 2017

Uh oh!

sanpii commented May 2, 2017

Uh oh!

mvrhov commented May 2, 2017

Uh oh!

sanpii commented May 2, 2017

Uh oh!

lunika commented Jun 1, 2017

Uh oh!

mvrhov commented Jun 1, 2017

Uh oh!

lunika commented Jun 2, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mvrhov Jun 8, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mvrhov commented Jul 26, 2017

Uh oh!

mvrhov commented Sep 26, 2017

Uh oh!

sanpii commented Oct 31, 2017

Uh oh!

mvrhov commented Oct 31, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sanpii commented Oct 31, 2017

Uh oh!

mvrhov commented Oct 31, 2017

Uh oh!

mvrhov commented Dec 13, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mvrhov commented Jan 17, 2018

Uh oh!

mvrhov commented Jan 17, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stood commented Jan 17, 2018

Uh oh!

mvrhov commented Jan 18, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

mvrhov Jun 8, 2017 •

edited

Loading

mvrhov commented Oct 31, 2017 •

edited

Loading

mvrhov commented Dec 13, 2017 •

edited

Loading

mvrhov commented Jan 17, 2018 •

edited

Loading