Remove invalid asserts from ASIO system#4618
Merged
SeanTAllen merged 1 commit intomainfrom Feb 18, 2025
Merged
Conversation
There's an ABA condition that can exist with how the ASIO system works in the runtime. There's guard conditions in various functions to ditch early for scenarios where this is encountered. A few years ago, some asserts were added to those guard clauses. Unfortunately, that defeats the purpose of the guards and will eventually result in assertions being triggered under load with a debug runtime. Without completely rewriting how the ASIO system works to be ABA friendly, these asserts are a bad idea. I don't feel up to doing a rewrite at this time, so I am removing the asserts.
ponylang-main
added
the
discuss during sync
ponylang-main
removed
the
discuss during sync
SeanTAllen
added a commit
that referenced
this pull request
Mar 7, 2025
This reverts commit 9c95489.
SeanTAllen
added a commit
that referenced
this pull request
Mar 7, 2025
This reverts commit 7ffad44.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's an ABA condition that can exist with how the ASIO system works in the runtime. There's guard
conditions in various functions to ditch early for scenarios where this is encountered.
A few years ago, some asserts were added to those guard clauses. Unfortunately, that defeats the purpose of the guards and will eventually result in assertions being triggered under load with a debug runtime.
Without completely rewriting how the ASIO system works to be ABA friendly, these asserts are a bad idea. I don't feel up to doing a rewrite at this time, so I am removing the asserts.