Fix "not really failing" Windows stress tests#4653
Merged
SeanTAllen merged 1 commit intomainfrom Mar 6, 2025
Merged
Conversation
ponylang-main
added
the
discuss during sync
SeanTAllen
force-pushed
the
fix-windows-error-code-stress-test
branch
from
6964d7e to
a03c8f6
Compare
Sometime with Windows stress tests, the process would finish fine but LLDB would return a non-zero exit code for itself thereby failing the process. This was not good. We will now check the process under test code for success/failure rather than the debugger exit.
SeanTAllen
force-pushed
the
fix-windows-error-code-stress-test
branch
from
a03c8f6 to
404fa2c
Compare
ponylang-main
removed
the
discuss during sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometime with Windows stress tests, the process would finish fine but LLDB would return a non-zero exit code for itself thereby failing the process. This was not good.
We will now check the process under test code for success/failure rather than the debugger exit.