Add JsonPrinter for serializing any JsonValue#5084
Draft
SeanTAllen wants to merge 1 commit intomainfrom
Draft
Conversation
Demonstrates the approach discussed in ponylang/rfcs#223 — expose _JsonPrint's functionality through a public JsonPrinter primitive with print() and pretty() methods, rather than the Json.print() wrapper proposed in the RFC.
ponylang-main
added
the
discuss during sync
SeanTAllen
removed
the
discuss during sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Demonstration of the approach discussed in ponylang/rfcs#223.
Rather than a
Jsonwrapper primitive that re-wrapsJsonParser.parse()and adds aprint()method, this exposes aJsonPrinterprimitive that mirrorsJsonParser:JsonPrinter.print(value)— compact JSON serialization of anyJsonValueJsonPrinter.pretty(value)— pretty-printed serialization with configurable indentBoth delegate to the existing
_JsonPrintinternal primitive.JsonParser,JsonObject.string(), andJsonArray.string()are unchanged.This fills the gap where
_JsonPrintalready handles allJsonValuevariants correctly (propernullforNone, escaped/quoted strings, etc.) but isn't accessible to users.