Fix pony-lsp diagnostic test failure on OpenBSD#5085
Merged
SeanTAllen merged 1 commit intomainfrom Mar 28, 2026
Merged
Conversation
On OpenBSD, get_compiler_exe_path relies entirely on argv0 to find the executable (no /proc/self/exe or KERN_PROC_PATHNAME). The diagnostic test was passing an empty string for argv0, so the compiler couldn't locate the builtin package. Other platforms ignored argv0 and used OS-specific mechanisms, masking the bug.
ponylang-main
added
the
discuss during sync
ponylang-main
removed
the
discuss during sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On OpenBSD,
get_compiler_exe_pathrelies entirely on argv0 to find the executable — there's no/proc/self/exeorKERN_PROC_PATHNAMEsysctl available. The diagnostic test was passing an empty string for argv0, so the compiler couldn't locate thebuiltinpackage and failed with "couldn't locate this path" instead of producing the expected type errors.Other platforms (Linux, macOS, FreeBSD) use OS-specific mechanisms that ignore argv0 entirely, which masked the bug.
The fix passes the actual argv0 from
h.env.args(0)?toPonyCompiler, matching whatmain.ponyalready does in production.