Fix with tuple only processing first binding in build_with_dispose#5095
Merged
SeanTAllen merged 1 commit intomainfrom Apr 1, 2026
Merged
Fix with tuple only processing first binding in build_with_dispose#5095SeanTAllen merged 1 commit intomainfrom
SeanTAllen merged 1 commit intomainfrom
Conversation
The loop in build_with_dispose returned on the first recursive call, so only the first tuple element was processed. Later `_` patterns were not diagnosed as errors, and dispose calls were only emitted for the first binding. Use the error accumulation pattern (matching sugar_match_capture) so every element is walked and all diagnostics are reported at once. Add three libponyc regression tests: dontcare in second position, both dontcare (verifies accumulation), and a happy-path two-element tuple compile. Replaces #5077
SeanTAllen
added
the
changelog - fixed
ponylang-main
added
the
discuss during sync
ponylang-main
removed
the
discuss during sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The loop in
build_with_disposereturned on the first recursive call, so only the first tuple element was processed. Later_patterns were not diagnosed as errors, and dispose calls were only emitted for the first binding.Uses the error accumulation pattern (matching
sugar_match_capture) so every element is walked and all diagnostics are reported at once.Adds three libponyc regression tests: dontcare in second position (1 error), both dontcare (2 errors, verifying accumulation), and a happy-path two-element tuple compile.
Replaces #5077.