Fix memory leak in Windows networking subsystem#5096
Merged
SeanTAllen merged 1 commit intomainfrom Apr 1, 2026
Merged
Conversation
The WSAEWOULDBLOCK case in pony_os_writev and pony_os_send returned without calling iocp_destroy, leaking the iocp_t and permanently elevating the token's refcount. Closes #5090
SeanTAllen
added
the
changelog - fixed
ponylang-main
added
the
discuss during sync
Member
Author
|
ad-hoc stress test run: https://github.com/ponylang/ponyc/actions/runs/23865002258 |
ponylang-main
removed
the
discuss during sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both
pony_os_writevandpony_os_sendallocate aniocp_tviaiocp_createbefore callingWSASend. IfWSASendfails withWSAEWOULDBLOCK, the functions returned without callingiocp_destroy, leaking the allocation and permanently elevating the IOCP token's refcount. Over time this could cause unbounded memory growth.The fix adds the missing
iocp_destroy(iocp)call to theWSAEWOULDBLOCKcase in both functions, matching the cleanup already done in thedefaulterror case.Closes #5090