Add LSP hover integration test coverage for literals, constructors, methods, and this#5108
Merged
Add LSP hover integration test coverage for literals, constructors, methods, and this#5108
this#5108Conversation
Adds a dedicated _literals.pony fixture and test covering integer, hex, binary, float, string, character, and boolean literals — asserting no hover result is returned for literal values. Adds constructor and method declaration hover checks to the class test, behavior hover to the actor test, and a this-reference check (also no hover). Improves the null- result error message to show expected strings rather than raw JSON.
Renames _HoverWorkspace* test classes to _HoverIntegration* and _HoverWorkspaceServer to _HoverLspServer.
ponylang-main
added
the
discuss during sync
ponylang-main
added
discuss during sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The existing hover integration tests cover top-level entity declarations but are missing tests for constructors, method declarations,
fun refreceivers,this, parameters, and literal values. The test classes and shared server are named after the workspace fixture directory rather than their role.Changes
_literals.ponyfixture andhover/integration/literalstest, covering integer, hex, binary, float, string, character, and boolean literals — asserting no hover result for literal values and correct type strings for their variable declarationsfun refmethod to_function.ponyand tests its declaration hover; addsthis-reference checks (no hover) in the function testh.long_test()into_HoverLspServer.hover()so individual tests don't need to call it_HoverWorkspace*to_HoverIntegration*and the shared server to_HoverLspServerContinues on from #5106 and #5107.