Fix pony-lint blank-lines rule false positives on multi-line docstrings#5109
Merged
SeanTAllen merged 1 commit intomainfrom Apr 4, 2026
Merged
Fix pony-lint blank-lines rule false positives on multi-line docstrings#5109SeanTAllen merged 1 commit intomainfrom
SeanTAllen merged 1 commit intomainfrom
Conversation
_MaxLineVisitor only checked node.line() for AST nodes, which reports only the start line of string literals. For multi-line docstrings, this meant blank lines inside the docstring body were miscounted as blank lines between members. The fix uses end_pos() to get the actual end line for multi-line TK_STRING nodes, scoped to strings whose token_value contains a newline (single-line and empty strings skip end_pos() due to a pre-existing parsing bug in that method for short strings). Also restores multi-paragraph docstrings in pony-lsp that were collapsed in #5098 as a workaround for this bug. Closes #5099
SeanTAllen
added
the
changelog - fixed
ponylang-main
added
the
discuss during sync
ponylang-main
removed
the
discuss during sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_MaxLineVisitoronly checkednode.line()for AST nodes, which reports only the start line of string literals. For multi-line docstrings, blank lines inside the docstring body were miscounted as blank lines between members, causing false positives on methods and fields preceded by a member with a multi-paragraph docstring.The fix uses
end_pos()to get the actual end line for multi-lineTK_STRINGnodes, scoped to strings whosetoken_valuecontains a newline — single-line and empty strings skipend_pos()due to a pre-existing parsing bug in that method for short strings.Also restores multi-paragraph docstrings in pony-lsp that were collapsed in #5098 as a workaround.
Closes #5099