Fix FloatingPoint.frexp returning unsigned exponent#5113
Merged
SeanTAllen merged 1 commit intomainfrom Apr 4, 2026
Merged
Conversation
SeanTAllen
added
the
changelog - fixed
ponylang-main
added
the
discuss during sync
SeanTAllen
removed
the
changelog - fixed
C's frexp writes a signed int for the exponent. The Pony wrapper declared it as U32, silently reinterpreting negative exponents as large positive values. Closes #5103
SeanTAllen
force-pushed
the
fix-frexp-return-type
branch
from
8025745 to
7847c98
Compare
ponylang-main
removed
the
discuss during sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
C's
frexpwrites a signedintfor the exponent. The Pony wrapper declared it asU32, silently reinterpreting negative exponents as large positive values. Changed toI32across the FFI declaration, theFloatingPointtrait, and theF32/F64implementations.Closes #5103