Track shared library changes for tool rebuilds#5148
Merged
SeanTAllen merged 1 commit intomainfrom Apr 7, 2026
Merged
Conversation
Each tool's build command only depended on its own .pony files, so changes to the shared pony_compiler library under tools/lib/ didn't trigger rebuilds. Add a stamp file that globs tools/lib/*.pony and have each tool depend on it. Closes #5142
ponylang-main
added
the
discuss during sync
ponylang-main
removed
the
discuss during sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each tool's build command only depended on its own
.ponyfiles, so changes to the sharedpony_compilerlibrary undertools/lib/didn't trigger tool rebuilds — you had to manually delete the binary ormake clean.Adds a CMake stamp file that globs all
.ponyfiles undertools/lib/and have each tool's build command depend on it. Adding new shared libraries underlib/only requires updating the glob in the top-level CMakeLists.txt.Closes #5142