Merged
Conversation
timerfd_create and timerfd_settime return values were unchecked in the epoll ASIO backend. If either call failed, the timer silently never fired and the actor waited forever. Check both return values and send ASIO_ERROR to the actor on failure, matching the existing pattern for epoll_ctl failures. Closes #5129
SeanTAllen
added
the
changelog - fixed
ponylang-main
added
the
discuss during sync
ponylang-main
removed
the
discuss during sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
timerfd_createandtimerfd_settimereturn values were unchecked in the epoll ASIO backend. If either call failed, the timer silently never fired and the actor waited forever for a notification that never came.Now checks both return values and sends
ASIO_ERRORto the actor on failure, matching the existing pattern forepoll_ctlfailures in the same file.