Strengthen NonExistentTable test to verify failure details#125
Merged
SeanTAllen merged 1 commit intomainfrom Feb 14, 2026
Merged
Strengthen NonExistentTable test to verify failure details#125SeanTAllen merged 1 commit intomainfrom
SeanTAllen merged 1 commit intomainfrom
Conversation
The test previously only checked query identity on failure, ignoring the failure value entirely (there was a TODO to fix this). Now it also verifies that the failure is an ErrorResponseMessage with SQLSTATE 42P01 (undefined_table), catching any unexpected failure type or error code.
ponylang-main
added
the
discuss during sync
ponylang-main
removed
the
discuss during sync
SeanTAllen
added a commit
that referenced
this pull request
Feb 15, 2026
Streaming queries use the extended query protocol with Execute(max_rows) to deliver results in windowed batches via PortalSuspended, rather than buffering all rows in memory. The client controls flow through fetch_more() and close_stream() on Session, receiving batches via pg_stream_batch on StreamingResultReceiver. Adds _StreamingQueryInFlight query sub-state with _completing and _error guards to prevent duplicate Sync and post-completion Execute messages. Dispatch for fetch_more/close_stream uses match on concrete type in _SessionLoggedIn rather than the _QueryState interface. Design: #125
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
_NonExistentTableQueryReceiver.pg_query_failedcallback previously only checked query identity, ignoring the failure value entirely (there was a TODO to fix this). Now it also verifies that the failure is anErrorResponseMessagewith SQLSTATE42P01(undefined_table), catching any unexpected failure type or error code.Also fixes a pre-existing typo ("paramter" → "parameter") in a failure message.