Fix array element codec errors falling back instead of propagating#167
Merged
SeanTAllen merged 1 commit intomainfrom Mar 15, 2026
Merged
Conversation
SeanTAllen
added
the
changelog - fixed
ponylang-main
added
the
discuss during sync
SeanTAllen
removed
the
changelog - fixed
Array element codec errors were caught by the same try/else that handles structural parsing errors, causing them to silently fall back to String/RawBytes instead of propagating. Split array decoding into structural parsing (errors fall back) and element decoding (errors propagate). Closes #158
SeanTAllen
force-pushed
the
fix-array-element-codec-error-propagation
branch
from
945c237 to
e0e9852
Compare
ponylang-main
removed
the
discuss during sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Array element codec errors in
CodecRegistry.decode()were caught by the same try/else that handles structural parsing errors, causing them to silently fall back toString/RawBytesinstead of propagating to the caller. A corrupt int4 value inside an int4[] would quietly become aRawBytesorStringinstead of erroring.Split array decoding into two phases: structural parsing (
_parse_binary_array/_parse_text_array) where errors fall back, and element decoding (_decode_array_elements) where errors propagate. This matches the behavior scalar codecs already have.Closes #158