Reject invalid with_array_type registrations#169
Merged
SeanTAllen merged 1 commit intomainfrom Mar 16, 2026
Merged
Conversation
SeanTAllen
added
the
changelog - changed
ponylang-main
added
the
discuss during sync
This was referenced Mar 15, 2026
SeanTAllen
force-pushed
the
reject-invalid-array-type-registration
branch
from
5fbcfa2 to
92b4a36
Compare
SeanTAllen
removed
the
changelog - changed
with_array_type is now partial. It errors if the registration would cause recursive decode (element OID is itself an array OID), collide with an existing scalar or built-in array OID, use an OID already registered as a custom element OID, or self-reference. Previously these misconfigurations were silently accepted and would cause incorrect behavior or stack overflow at decode time. Closes #168
SeanTAllen
force-pushed
the
reject-invalid-array-type-registration
branch
from
b3e410b to
239b0c6
Compare
ponylang-main
removed
the
discuss during sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
with_array_type()is now partial. It errors if the registration would cause recursive decode (element OID is itself an array OID), collide with an existing scalar or built-in array OID, or self-reference (array_oid == element_oid). Previously these misconfigurations were silently accepted and would cause incorrect behavior or stack overflow at decode time.Closes #168