Reject array OID collisions in with_codec#174
Merged
SeanTAllen merged 1 commit intomainfrom Mar 16, 2026
Merged
Conversation
with_array_type rejects array_oid values that collide with registered scalar codecs, but with_codec didn't perform the reverse check against array OIDs. This allowed registering a scalar codec for a built-in or custom array OID, producing a silently unreachable dead codec since decode() always takes the array path first. Closes #173
ponylang-main
added
the
discuss during sync
ponylang-main
removed
the
discuss during sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
with_array_typerejectsarray_oidvalues that collide with registered scalar codecs, butwith_codecdidn't perform the reverse check against array OIDs. This allowed registering a scalar codec for a built-in or custom array OID, producing a silently unreachable dead codec sincedecode()always takes the array path first.with_codecnow checks_ArrayOidMap.is_array_oid(oid)and_custom_array_element_oids.contains(oid)and errors on collision.Closes #173