Merged
Conversation
Thread lori's ConnectionTimeout through ServerConnectInfo to Session so users can bound the TCP connection phase. Without this, connections to unreachable hosts hang until the OS-level TCP timeout. Design: #72
SeanTAllen
added
the
changelog - added
ponylang-main
added
the
discuss during sync
ponylang-main
removed
the
discuss during sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thread lori's
ConnectionTimeoutthroughServerConnectInfotoSessionso users can bound the TCP connection phase. Without this, connections to unreachable hosts hang until the OS-level TCP timeout.ServerConnectInfogains an optionalconnection_timeoutparameter (defaultNone). When set, lori firesConnectionFailedTimeoutif TCP doesn't connect in time — the existing failure mapping (from PR #177) delivers it topg_session_connection_failed._CancelSenderdoes not use the connection timeout — cancel connections are fire-and-forget with no user callback, so a timeout would have no observable effect.Design: #72