Open
Conversation
The serialise package is a security footgun that's only safe with fully trusted data. It also depends on runtime code that uses pony_error, which is being removed. Rather than invest unknown effort in a package with fundamental safety problems, remove it.
ponylang-main
added
discuss during sync
SeanTAllen
added
the
discuss during sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The serialise package is a security footgun that's only safe with fully trusted data. Deserializing untrusted data can crash the program or give hostile code unauthorized access to the machine.
It also depends on runtime code that uses pony_error, which is being removed (ponylang/ponyc#5002). Updating serialise to work without pony_error is an unknown amount of effort, and given the security issues, that effort isn't justified.