Skip to content

Apply consistent pony-lsp start up debug logging#11

Merged
SeanTAllen merged 2 commits intoponylang:mainfrom
orien:pony-lsp-debug-logging
Feb 12, 2026
Merged

Apply consistent pony-lsp start up debug logging#11
SeanTAllen merged 2 commits intoponylang:mainfrom
orien:pony-lsp-debug-logging

Conversation

@orien
Copy link
Copy Markdown
Member

@orien orien commented Feb 12, 2026

Some minor development niceties.

@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label Feb 12, 2026
@orien orien force-pushed the pony-lsp-debug-logging branch from d474dd6 to 7ccbdf0 Compare February 12, 2026 12:16
@orien orien force-pushed the pony-lsp-debug-logging branch from 7ccbdf0 to 27e1d11 Compare February 12, 2026 12:17
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've corrected the indentation in this file.

Comment on lines -81 to +89
outputChannel.appendLine("PonyLSP client ready");
outputChannel.appendLine("Pony language server client starting…");
// Start the client. This will also launch the server
return client.start().catch(reason => {
window.showWarningMessage(`Failed to run Pony Language Server (PLS): ${reason}`);
showPony(false);
client = undefined;
});
return client
.start()
.then(() => {
outputChannel.appendLine("Pony language server client ready");
})
.catch((reason) => {
window.showWarningMessage(`Pony language server client failed: ${reason}`);
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the debug logging to indicate when pony-lsp starts, is ready, or fails.

@orien
Copy link
Copy Markdown
Member Author

orien commented Feb 12, 2026

Ready for review. Thanks.

@SeanTAllen SeanTAllen merged commit 65d638f into ponylang:main Feb 12, 2026
7 checks passed
@ponylang-main ponylang-main removed the discuss during sync Should be discussed during an upcoming sync label Feb 12, 2026
@orien orien deleted the pony-lsp-debug-logging branch February 12, 2026 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants