Merged
Conversation
jackpot51
approved these changes
Jan 27, 2026
leviport
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update libcosmic to fix icon rendering crashes
Updates libcosmic dependency to pull in upstream fixes from pop-os/iced that prevent crashes when encountering invalid or malformed icon files.
This was done with
cargo update -p libcosmicBackground
Issue pop-os/cosmic-epoch#2452 reported crashes in both cosmic-launcher and cosmic-applibrary when encountering malformed SVG icons. This was fixed upstream in pop-os/iced#249 by wrapping
resvg::renderin a panic handler.I encountered a similar crash when Tizen Studio .desktop files reference binary .ico icon files (which violate the freedesktop.org icon spec). The crash manifests as:
The root cause appears to be the same - icon parsing failures corrupting application metadata. Updating libcosmic to include the iced fixes resolves both the SVG and .ico crashes.
Changes
Testing
Fixes
Fixes pop-os/cosmic-epoch#2452 - SVG rendering crashes (mentions applibrary launcher)
Related
Third-party applications may use non-standard icon formats. The launcher should handle these gracefully instead of crashing.