chore: apply (more pedantic) clippy suggestions

[Cheong-Lau]

Also some slight refactors for readability/minor performance.

[leviport]

I noticed a regression in the bluetooth and wifi applets after this change. The lists of bluetooth devices and wifi access points are empty when they shouldn't be.

Before:

After:

[Cheong-Lau]

I noticed a regression in the bluetooth and wifi applets after this change. The lists of bluetooth devices and wifi access points are empty when they shouldn't be.

I didn't test those properly, my bad 😓, I don't have networkmanager on my system.

I realised that using Column::from_vec() and Row::from_vec() is a dumb idea most of the time, since it doesn't inspect the child elements to fit to their size (which is what broke this). Using with_children() like before works, but it reallocates an already allocated Vec for no real reason. Instead, when building a Vec<Element>, just push() directly into a Row or Column instead. It fits to the size properly and doesn't need to reallocate at the end. Couldn't do anything about the places where the len() of the Vec was needed, but oh well.

[leviport]

No worries, thanks for the quick fix!

Upon retesting, the wifi and bluetooth lists are now populating as expected. I didn't notice any other issues with any of the other applets. I think this is good to go.