Skip to content

improv(app-list): get app icons from icon theme #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
YkdWaWEzVmphR1Z1 wants to merge 1 commit into from
Closed

improv(app-list): get app icons from icon theme #542

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions cosmic-app-list/src/app.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,8 +181,7 @@ impl DockItem {

let app_icon = AppletIconData::new(applet);

let cosmic_icon = IconSource::from_unknown(desktop_info.icon().unwrap_or_default())
.as_cosmic_icon()
let cosmic_icon = cosmic::widget::icon::from_name(desktop_info.icon().unwrap_or_default())
Copy link
Contributor

@wash2 wash2 Jul 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe IconSource::from_unknown is actually correct. Some icons are absolute paths. Maybe app library and launcher should be updated instead. Is the app tray showing the wrong icon?

Copy link
Contributor Author

@YkdWaWEzVmphR1Z1 YkdWaWEzVmphR1Z1 Jul 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not applying the icon theme, here Qogir-ubuntu.
image
It could be checked if the path is absolute or IconSource could be improved.

.size(app_icon.icon_size);

let dots = if toplevels.is_empty() {
Expand Down