Conversation
5ecb3d9 to
b8787d6
Compare
|
I think your code can cause problem for the ordering of the date. In France its day/month/year (like it should 😄). Icu handle it. In the future, we could use slitToPart for that ( unicode-org/icu4x#4936 (comment)). For now, i would suggest to find a way to split it for Japanese (it possible ?) |
|
It's now top-to-bottom on the size of the dates, which should probs stay the same in every locale (I'm an Australian who also uses day/month/year, so maybe I'm biased in this...). So the month (09) at the top, then day (26) below it, and the rest of the date below that (hour then minute). Should that be done? I could change it to properly format Japanese dates (looks like |
|
Would it be better if I split the patch for the seconds in the vertical format into a different PR, or is it fine to keep it in this? |
This PR contains 2 fixes to the vertical time applet.
This also fixes Japanese time format overflowing due to it previously splitting based on a whitespace (which doesn't exist in the Japanese locale)
The table below shows this change.
Japanese Time Format Causing Overflow:
