Print #336
Open
Print #336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove Extra-line
|
Make sure to support the xdg desktop portal dialog: https://docs.rs/ashpd/latest/ashpd/desktop/print/index.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1- It work
2- The integration is clean in my opinion
3- The big difference is that this time, the structure is a lot more complete; there is a dialog to confirm we want to print to prevent mistakes and use Fluent files.
To my knowledge it will work with any Linux, maybe Redox too, and have does not have more dependencies.
It could be better but before we can have a cosmic-print-dialog app, this is the best we can do, everything embeded.