Skip to content

Fix: Immediately apply keyboard layout changes in greeter #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PerfAct-Flip wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: Immediately apply keyboard layout changes in greeter #313

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/common.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,12 @@ impl<M: From<Message> + Send + 'static> Common<M> {
}
if let Some(comp_config_handler) = &self.comp_config_handler {
match comp_config_handler.set("xkb_config", xkb_config) {
Ok(()) => tracing::info!("updated cosmic-comp xkb_config"),
Ok(()) => {
tracing::info!("updated cosmic-comp xkb_config");
if let Err(err) = comp_config_handler.reload() {
Copy link
Member

@jackpot51 jackpot51 Oct 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did you get this from? This function does not exist.

Copy link
Author

@PerfAct-Flip PerfAct-Flip Oct 2, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad!! The changes are live in my fork. I used D-Bus method to trigger comp_config_handler.reload(). Can you review it. repo link:- https://github.com/PerfAct-Flip/cosmic-greeter

Copy link
Member

@jackpot51 jackpot51 Oct 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you put those changes into this PR?

Copy link
Author

@PerfAct-Flip PerfAct-Flip Oct 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

tracing::error!("failed to reload cosmic-comp config: {}", err);
}
},
Err(err) => tracing::error!("failed to update cosmic-comp xkb_config: {}", err),
}
}
Expand Down