feat: add better error handling for dependencies not in PATH#321
Open
Pandapip1 wants to merge 2 commits intopop-os:masterfrom
Open
feat: add better error handling for dependencies not in PATH#321Pandapip1 wants to merge 2 commits intopop-os:masterfrom
Pandapip1 wants to merge 2 commits intopop-os:masterfrom
Conversation
This allows packagers to confirm that their package is packaged correctly at check time
Pandapip1
commented
Oct 6, 2025
| cosmic-randr-shell = { workspace = true } | ||
| kdl.workspace = true | ||
| color-eyre.workspace = true | ||
| which = "8.0.0" |
Contributor
Author
There was a problem hiding this comment.
It seems that it brings in a total of two other dependencies (winsafe and env_home). This seems reasonable, although obviously the former is unneeded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates cosmic-greeter to use the PATH to search for binaries such as orca and coreutils's env, and also logs when they could not be found rather than failing when the command is attempted to be run. It also adds a command for packagers to be able to validate that they've correctly packaged cosmic-greeter with its dependencies.
CC @HeitorAugustoLN, will require a minor change to the nixpkgs drv if merged (removing the
postPatchand adding the deps to the PATH, and addingcosmic-greeter --check-depstocheckPhase)