Skip to content

fix(nixos): use correct process name#138

Open
kajusnau wants to merge 1 commit into
pop-os:masterfrom
kajusnau:nixos-process-name
Open

fix(nixos): use correct process name#138
kajusnau wants to merge 1 commit into
pop-os:masterfrom
kajusnau:nixos-process-name

Conversation

@kajusnau

Copy link
Copy Markdown

In latest nixos-unstable cosmic-panel (or any cosmic tool for that matter) is no longer wrapped and is running under cosmic-panel.
This essentially reverts the change done in d2623cb

Tested manually on NixOS using an overlay for the cosmic-initial-setup package

  • I have disclosed use of any AI generated code in my commit messages.
    • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
    • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.

Signed-off-by: Kajus Naujokaitis <kajusn@gmail.com>
@kajusnau

Copy link
Copy Markdown
Author

Turns out there was an issue with the wrapping of cosmic packages in nixpkgs.
Will be addressed by NixOS/nixpkgs#534694.

@Pandapip1

Copy link
Copy Markdown

We should probably just patch killall and pkill like we have with ananicy-cpp (https://github.com/NixOS/nixpkgs/blob/nixos-unstable/pkgs/by-name/an/ananicy-cpp/match-wrappers.patch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants