launcher: crisp category/app icons; size-aware themed lookup; prefer SVG only for -symbolic#351
Conversation
3b5eb6e to
380d329
Compare
|
This seems to be working alright. I'm not seeing a difference in the quality of any icons, even ones which I thought were kind of poor to start with (e.g. the OBS icon being jagged). Do you have any specific examples of icons that weren't working well before this change? |
|
I stupidly didn't track the exact app I had this issue with, I think it was VMWare Desktop or some of the png's that Chromium generated for web apps like WhatsApp, etc. |
| ]))); | ||
| if name.ends_with("-symbolic") { | ||
| named = named.prefer_svg(true); | ||
| } |
There was a problem hiding this comment.
Not necessary since -symbolic is already checked when creating an icon by name.
778a68f to
be0b1d5
Compare
|
Resolved conflicts by keeping upstream’s icon‑handle caching; PR now only changes category icons to render as symbolic (one‑line tweak). |
jacobgkau
left a comment
There was a problem hiding this comment.
My understanding is that this will no longer affect app icons (I tried installing the WhatsApp web app in Google Chrome, as well as VMware Workstation, but didn't see a change with either).
The only change to any of the category icons I'm seeing is the magnifying glass for web searches-- it's switching to what I assume is its symbolic variant.
Before (dark mode):
After (dark mode):
Before (light mode):
After (light mode):
Seeing as it's still visible with both the dark and light default themes, I'm not seeing a problem with this.
Regression testing checklist passed:
Launcher
- All windows on all workspaces appear on launch
- Choosing an app on another workspace moves workspaces and focus to that app
- Launching an application works
- Typing text and then removing it will re-show those windows
- Search works for applications and windows
- Search works for COSMIC settings panels
- Open windows are sorted above applications (e.g. "firefox")
- t: executes a command in a terminal
- : executes a command in sh
- = calculates an equation
- Search results are as expected:
calreturns LibreOffice Calc firstpopsreturns Popsicle firstshopreturns the COSMIC Store first
Category icons: symbolic + prefer_svg + size(16).
App icons: size-aware themed lookup; only prefer SVG for -symbolic; full-color app icons prefer raster. Addresses fuzzy/aliased icons.