Skip to content

launcher: crisp category/app icons; size-aware themed lookup; prefer SVG only for -symbolic#351

Open
stephanbuys wants to merge 1 commit into
pop-os:masterfrom
stephanbuys:feat/launcher-icon-quality-2025-10-29
Open

launcher: crisp category/app icons; size-aware themed lookup; prefer SVG only for -symbolic#351
stephanbuys wants to merge 1 commit into
pop-os:masterfrom
stephanbuys:feat/launcher-icon-quality-2025-10-29

Conversation

@stephanbuys
Copy link
Copy Markdown

Category icons: symbolic + prefer_svg + size(16).
App icons: size-aware themed lookup; only prefer SVG for -symbolic; full-color app icons prefer raster. Addresses fuzzy/aliased icons.

@stephanbuys stephanbuys marked this pull request as ready for review October 29, 2025 11:20
@stephanbuys stephanbuys force-pushed the feat/launcher-icon-quality-2025-10-29 branch from 3b5eb6e to 380d329 Compare November 20, 2025 09:37
@jacobgkau jacobgkau requested review from a team November 20, 2025 16:27
@jacobgkau jacobgkau self-assigned this Nov 20, 2025
@jacobgkau
Copy link
Copy Markdown
Member

This seems to be working alright. I'm not seeing a difference in the quality of any icons, even ones which I thought were kind of poor to start with (e.g. the OBS icon being jagged). Do you have any specific examples of icons that weren't working well before this change?

@stephanbuys
Copy link
Copy Markdown
Author

I stupidly didn't track the exact app I had this issue with, I think it was VMWare Desktop or some of the png's that Chromium generated for web apps like WhatsApp, etc.
This just nudges the system to prefer SVG if it's available. But the more important PR is really pop-os/cosmic-applets#1123, which this was part of.

Comment thread src/app.rs Outdated
])));
if name.ends_with("-symbolic") {
named = named.prefer_svg(true);
}
Copy link
Copy Markdown
Member

@mmstick mmstick Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessary since -symbolic is already checked when creating an icon by name.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dropped in the rebase

@stephanbuys stephanbuys force-pushed the feat/launcher-icon-quality-2025-10-29 branch from 778a68f to be0b1d5 Compare December 12, 2025 11:58
@stephanbuys
Copy link
Copy Markdown
Author

Resolved conflicts by keeping upstream’s icon‑handle caching; PR now only changes category icons to render as symbolic (one‑line tweak).

Copy link
Copy Markdown
Member

@jacobgkau jacobgkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that this will no longer affect app icons (I tried installing the WhatsApp web app in Google Chrome, as well as VMware Workstation, but didn't see a change with either).

The only change to any of the category icons I'm seeing is the magnifying glass for web searches-- it's switching to what I assume is its symbolic variant.

Before (dark mode):

Image

After (dark mode):

Image

Before (light mode):

Image

After (light mode):

Image

Seeing as it's still visible with both the dark and light default themes, I'm not seeing a problem with this.

Regression testing checklist passed:

Launcher

  • All windows on all workspaces appear on launch
  • Choosing an app on another workspace moves workspaces and focus to that app
  • Launching an application works
  • Typing text and then removing it will re-show those windows
  • Search works for applications and windows
  • Search works for COSMIC settings panels
  • Open windows are sorted above applications (e.g. "firefox")
  • t: executes a command in a terminal
  • : executes a command in sh
  • = calculates an equation
  • Search results are as expected:
    • cal returns LibreOffice Calc first
    • pops returns Popsicle first
    • shop returns the COSMIC Store first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants