Support file:// URLs in app_icon field#132
Merged
Merged
Conversation
Handle file:// URLs in the app_icon field for notifications from Chromium-based browsers (e.g., Helium, Chrome, Chromium). These browsers send temporary icon file paths like: file:///tmp/org.chromium.Chromium.scoped_dir.XXX/logo.png Previously, COSMIC tried to load these as icon names via from_name(), which failed. Now we: - Detect file:// URL prefix in app_icon - Parse and convert to file path - Load icon using from_path() instead This allows app icons to display correctly in notifications from web applications running in Chromium-based browsers.
jackpot51
approved these changes
Feb 6, 2026
leviport
approved these changes
Feb 6, 2026
olafkfreund
added a commit
to olafkfreund/cosmic-ext-notifications-ng
that referenced
this pull request
Feb 11, 2026
Sync upstream change from pop-os#132. When app_icon contains a file:// URL, parse it and use icon::from_path() instead of treating it as an icon name. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
3 tasks
olafkfreund
added a commit
to olafkfreund/cosmic-ext-notifications-ng
that referenced
this pull request
Feb 11, 2026
Sync upstream change from pop-os#132. When app_icon contains a file:// URL, parse it and use icon::from_path() instead of treating it as an icon name. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle file:// URLs in the app_icon field for notifications from Chromium-based browsers (e.g., Helium, Chrome, Chromium).
These browsers send temporary icon file paths like:
file:///tmp/org.chromium.Chromium.scoped_dir.XXX/logo.png
Previously, COSMIC tried to load these as icon names via from_name(), which failed. Now we:
This allows app icons to display correctly in notifications from web applications running in Chromium-based browsers.
This was originally posted as part of #130, which was closed in favor of #115. However, only part of #130 was related to the HTML stripping feature.