Skip to content

Move notification FDs to config#156

Merged
leviport merged 4 commits into
pop-os:masterfrom
git-f0x:master
Apr 29, 2026
Merged

Move notification FDs to config#156
leviport merged 4 commits into
pop-os:masterfrom
git-f0x:master

Conversation

@git-f0x

@git-f0x git-f0x commented Apr 25, 2026

Copy link
Copy Markdown
Contributor
  • I have disclosed use of any AI generated code in my commit messages.
    • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
    • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.

Moves the notification FDs to config, since util pulls in a lot of dependencies (and config seems like the better place for this). This prevents e.g. cosmic-session from pulling in 3000+ lines of Cargo.lock after a cargo update because of util (libcosmic), and instead it's only ~100.
Though I'm not sure if it's needed to pull in this crate just because of those 2 constants, and they're unlikely to change. Removing the dep from cosmic-session cuts over 400 lines in its Cargo.lock.

Updates dependencies and addresses clippy lints.

The last commit also removes the data and i18n folders, since a desktop file and placeholder icon don't seem to be needed for a notification daemon (it shows up in COSMIC Store), and localizations are unused.
Something similar should probably also be done for cosmic-bg.

util pulls in a large part of libcosmic
wash2
wash2 previously approved these changes Apr 27, 2026
@leviport leviport self-assigned this Apr 29, 2026
@git-f0x

git-f0x commented Apr 29, 2026

Copy link
Copy Markdown
Contributor Author

Any logs for why this failed to build? It builds and vendors fine locally.

@mmstick

mmstick commented Apr 29, 2026

Copy link
Copy Markdown
Member
just rootdir=debian/cosmic-notifications install
error: Justfile does not contain recipe `install`
make[1]: *** [debian/rules:31: override_dh_install] Error 1

git-f0x added 3 commits April 29, 2026 23:04
The localization doesn't seem to be used for anything, and the desktop file and placeholder icon also seem unneeded.
@git-f0x

git-f0x commented Apr 29, 2026

Copy link
Copy Markdown
Contributor Author

Oh, whoops. 😅
Should be fixed now.

@leviport leviport merged commit a899bfb into pop-os:master Apr 29, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants