Move notification FDs to config#156
Merged
Merged
Conversation
util pulls in a large part of libcosmic
5 tasks
wash2
previously approved these changes
Apr 27, 2026
Contributor
Author
|
Any logs for why this failed to build? It builds and vendors fine locally. |
Member
|
The localization doesn't seem to be used for anything, and the desktop file and placeholder icon also seem unneeded.
Contributor
Author
|
Oh, whoops. 😅 |
mmstick
approved these changes
Apr 29, 2026
leviport
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the notification FDs to config, since util pulls in a lot of dependencies (and config seems like the better place for this). This prevents e.g.
cosmic-sessionfrom pulling in 3000+ lines of Cargo.lock after acargo updatebecause of util (libcosmic), and instead it's only ~100.Though I'm not sure if it's needed to pull in this crate just because of those 2 constants, and they're unlikely to change. Removing the dep from
cosmic-sessioncuts over 400 lines in its Cargo.lock.Updates dependencies and addresses clippy lints.
The last commit also removes the data and i18n folders, since a desktop file and placeholder icon don't seem to be needed for a notification daemon (it shows up in COSMIC Store), and localizations are unused.
Something similar should probably also be done for
cosmic-bg.