feat: Option to show notifications over fullscreen windows#158
Open
hojjatabdollahi wants to merge 1 commit into
Open
feat: Option to show notifications over fullscreen windows#158hojjatabdollahi wants to merge 1 commit into
hojjatabdollahi wants to merge 1 commit into
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you're watching a video or palying a game in fullscreen you'd miss the "Battery Low" notification.
This PR adds an option to show None/All/UrgentOnly notifications over fullscreen windows.
Methodology:
In cosmic-comp Top layers are drawn behind the fullscreen layer and overlay is drawn over it.
By default all notifications are shown on a Top layer (current behavior) which means they're covered by a fullscreen surface. This draws the notifications on Top or Overlay surface depending on the config.