Conversation
5 tasks
|
I guess I missed that this requires another PR. It looks like pop-os/cosmic-settings-daemon#135 still has some work going on. I'll unassign myself for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires pop-os/cosmic-settings-daemon#135
This changes the behavior of
cosmic-osd confirm-headphonesto enable the settings daemon to take over the responsibility of selecting and applying profiles and their routes on behalf of cosmic-osd. The settings daemon will callcosmic-osd confirm-headphones --device IDto request a dialog and then cosmic-osd may use the device ID as an input to eitherSelectHeadphoneProfileorSelectHeadsetProfile. The settings daemon can then make better decisions about what to do since it's already tracking everything.This will also drop the dependency on libpipewire, libpulse, and the cosmic-settings pulse subscription. The audio server events for the volume OSD notifications will now come from the settings-daemon's varlink API as well.