Skip to content

panel-config: Add border_width property#283

Open
ryanabx wants to merge 2 commits into
pop-os:masterfrom
ryanabx-contrib:master
Open

panel-config: Add border_width property#283
ryanabx wants to merge 2 commits into
pop-os:masterfrom
ryanabx-contrib:master

Conversation

@ryanabx
Copy link
Copy Markdown
Contributor

@ryanabx ryanabx commented Nov 2, 2024

This commit adds a new property to the panel config, which allows users to specify a border for the panel.

The default is 0.0, and we don't expose this property in cosmic-settings.

Design approval pending :)

Example of a border_width of 1.0:

screenshot-2024-11-02-05-36-50

This commit adds a new property to the panel config, which allows users to specify a border for the panel.

Signed-off-by: Ryan Brue <ryanbrue.dev@gmail.com>
Signed-off-by: Ryan Brue <ryanbrue.dev@gmail.com>
@mmstick
Copy link
Copy Markdown
Member

mmstick commented Dec 31, 2024

Needs approval by @maria-komarova. Probably fine since it's not enabled by default.

@maria-komarova
Copy link
Copy Markdown

It's all right to add the property as long as it doesn't change the defaults.

@wash2
Copy link
Copy Markdown
Collaborator

wash2 commented Jan 2, 2025

There seems to be a bug relating to how the border is drawn, as it doesn't line up correctly when I've tested it.

@ryanabx
Copy link
Copy Markdown
Contributor Author

ryanabx commented Jan 22, 2025

There seems to be a bug relating to how the border is drawn, as it doesn't line up correctly when I've tested it.

Could be because I used the iced border_width property? Maybe that's an outer border instead of an inner border. If so, there might need to be some size adjustments to accommodate, but that might affect the size of applets? Maybe not, /shrug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants