fix: make dock corner radius respect system theme#529
Open
ZeusCraft10 wants to merge 1 commit into
Open
Conversation
Changed border_radius to Option<u32> to allow falling back to the theme's corner_radius when not set. Updated default dock config to None.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue pop-os/cosmic-epoch#2802 where the dock's corner radius did not match the "Slightly Round" system theme (or other user-selected corner radii).
Changes:
CosmicPanelConfigto changeborder_radiusfromu32toOption<u32>.cosmic-panel-binto use the theme'scorner_radiuswhenborder_radiusisNone.Panel(Top Bar) explicitly setsborder_radius: Some(0)(square/full-width).Docksetsborder_radius: None(adapts to system theme).Reasoning:
The previous implementation used a hardcoded default of
8(inpanel_config.rs) or12(incontainer_config.rsfor the Dock), which often clashed with the user's chosen theme settings. By allowingNone, we enable the dock to dynamically match the rest of the desktop environment.Fixes pop-os/cosmic-epoch#2802