Conversation
Do nothing here if the surface belongs to a different panel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two fixes here seem to solve the same problem as #470 in a cleaner way.
keyboard_leaveevents for a different panel, instead of closing popupsThe later change though seems to basically be a revert of #424, looking at the history of this code. But I don't really understand why that fix was needed. The applet clients create grabs, so cosmic-panel ends up creating a grab either way? Nor should "focus follows cursor" require a grab (or that would presumably be a compositor bug), and I'm not seeing issues with that...