add dock configuration options for length, position, and corner radius#1771
add dock configuration options for length, position, and corner radius#1771MiraiDevv wants to merge 2 commits into
Conversation
|
Requires design approval from @maria-komarova first. |
| EnableDock(bool), | ||
| DockLengthPercent(u16), | ||
| DockPositionPercent(u16), | ||
| DockCornerRadius(u16), |
There was a problem hiding this comment.
Shouldn't this be shared with the panel?
There was a problem hiding this comment.
So, while I was doing this, I even thought about that, but then I thought, "What if the user only wanted to change the size of the dock without affecting the panel's width?" If they wanted, I could create a hybrid between them. I would make a toggle button that, if activated by the user, would link the width of the dock and the panel, so both would have to be the same width while the toggle button is activated.
And then I would also make a slider to decrease and increase the panel's width separately when the user deactivates the toggle button. What do you think, @mmstick?
There was a problem hiding this comment.
You've added these enum variants to the dock's message type when it should be shared by both the dock and panel in the inner message type. The dock is just a second panel, and the panel is often used as a dock for those using the single panel layout.
There was a problem hiding this comment.
You've added these enum variants to the dock's message type when it should be shared by both the dock and panel in the inner message type. The dock is just a second panel, and the panel is often used as a dock for those using the single panel layout.
I'm not sure I understood exactly what you meant, but I made those changes, was that it?
|
It would be helpful to have a clear overview of the changes with corresponding screenshots. I also get a 404 when clicking on the PR link. |
Hi @maria-komarova, I think you should be able to click the link now! I'll record a video and also take screenshots of how things are and attach them to this PR! |
cosmic_panels_and_cosmic_settings.mp4Here is a video demonstrating the changes made, @maria-komarova @mmstick This video already includes the changes that were made to the cosmic-panel, in the PR that was linked to this one; if you want, I can put the same video there as well. |
…s, add custom labels for dock configuration
3 participants
The changes within the repository all pertain to the PR, which I will list below: pop-os/cosmic-panel#549