fix: increased hard-coded wallpapers limit from 100 to 500#1785
Draft
thegabriele97 wants to merge 1 commit into
Draft
fix: increased hard-coded wallpapers limit from 100 to 500#1785thegabriele97 wants to merge 1 commit into
thegabriele97 wants to merge 1 commit into
Conversation
Member
|
We should hold off on this until libcosmic has been rebased on iced 0.14, and cosmic-settings has also been rebased on that rebase of libcosmic. 500 images uses a lot of VRAM and CPU in the current version of iced used. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increase wallpaper directory load limit
This PR raises the hard-coded limit for loading wallpapers from a directory from 100 to 500.
fixes: #1356
The current limit of 100 is unnecessarily restrictive for users who use folders as wallpaper sources (e.g. slideshow-style setups) and is not configurable or user-visible, making the behavior appear unintended.
This change does not increase peak resource usage:
buffered(4)The increase improves usability while keeping the existing design and safeguards intact.