Skip to content

i18n: improvements#1885

Open
lorduskordus wants to merge 5 commits into
pop-os:masterfrom
lorduskordus:consistency
Open

i18n: improvements#1885
lorduskordus wants to merge 5 commits into
pop-os:masterfrom
lorduskordus:consistency

Conversation

@lorduskordus
Copy link
Copy Markdown
Contributor

@lorduskordus lorduskordus commented Mar 1, 2026

  • I have disclosed use of any AI generated code in my commit messages.
    • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
    • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.

displays_reset.webm

Changes

  • Makes "revert/keep display settings" dialog show proper sentences (see the video)
    • "..will revert .. in 2 seconds."
    • "..will revert .. in 1 second."
    • "..will revert .. now."
  • Adds spaces to a shortcut for consistency, as most of them include spaces
  • Adds missing trailing semicolons to keywords
  • Adds more display related keywords
    • User is likely to search for "monitor", "screen", "resolution",..
  • Fixes a few strings

Note

  • I found more minor issues mostly consisting of capitalization, but I'm not sure about the changes, so I decided to not include them in this PR. I might make a separate one just for that later.
  • If you want to look into it, most of them are in the Keyboard shortcuts menu
    • Input devices --> Keyboard --> View and customize shortcuts

@mmstick
Copy link
Copy Markdown
Member

mmstick commented Mar 2, 2026

I've noticed that merging changes to English keys will delete all unapproved translations of those keys. It may be better to suggest changes in Weblate and revert any pending translations that get discarded on approval.

@lorduskordus
Copy link
Copy Markdown
Contributor Author

Unfortunately I can't suggest changes to English ever since it was made read-only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants