Skip to content

feat: setting to show battery percentage in the panel#1975

Open
SammyMcFly wants to merge 5 commits into
pop-os:masterfrom
SammyMcFly:feat/show-battery-percentage
Open

feat: setting to show battery percentage in the panel#1975
SammyMcFly wants to merge 5 commits into
pop-os:masterfrom
SammyMcFly:feat/show-battery-percentage

Conversation

@SammyMcFly
Copy link
Copy Markdown
Contributor

The changes add a setting to have the cosmic-applet-battery show battery percentage in the panel.

This fixes one of two request from #617.

The title of the added setting is up for discussion. I added an English draft-title: "Show percentage", however, this might be too short or not descriptive enough. Perhaps "Show battery percentage in panel" might be better. Let me know what you think!

  • I have disclosed use of any AI generated code in my commit messages.
    • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
    • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.

@leviport leviport requested a review from a team May 27, 2026 20:24
@leviport
Copy link
Copy Markdown
Member

leviport commented May 27, 2026

Since this is a UI change, it will need approval from the UX team. I know the longer term strategy was to have this setting in applet settings once the applet settings system gets built out, but this seems like a good stop-gap in the meantime. It exposes the option in GUI, and there is definitely a lot of interest in the setting.

Here is a screenshot of the Power & Battery page with the new setting:
Screenshot_2026-05-27_14-23-23

From a quick test, this is working as expected. If UX is okay with the change, I'll run through regression testing.

@SammyMcFly
Copy link
Copy Markdown
Contributor Author

Since this is a UI change, it will need approval from the UX team. I know the longer term strategy was to have this setting in applet settings once the applet settings system gets built out, but this seems like a good stop-gap in the meantime. It exposes the option in GUI, and there is definitely a lot of interest in the setting.

Good to know. Will this be an extra page in cosmic settings or just a setting inside the applet? The latter I could take care of, for the former you will probably have a design laid out that I am not aware of.

@leviport
Copy link
Copy Markdown
Member

I believe the current plan is a page in Settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants