feat: add confirmation for resetting panel settings#1983
Open
Zij-IT wants to merge 1 commit into
Open
Conversation
a51fcb4 to
bae9977
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I accidentally reset my settings, and was surprised by the lack of a confirmation for the action. This PR would address #1967. I made the assumption that this being moved from libcosmic to cosmic-settings was an indication that this is something that was worth a PR.
This PR adds a confirmation dialog for panel settings after clicking on "Reset to default". The solution is based on the dialog found in the WiFi (
pages/networking/wifi.rs).This only implements the fix for the panel-settings. AFAICT this could also be applied to wallpaper, appearance and shortcuts, which all three use a simple "Reset to default" without confirmation. If this gets accepted, and a similar implementation is desired for the other locations, just let me know.
P.S.: I ran
just checkincosmic-settingswhich resulted in about 252 unrelated warnings.Edit: Force push was because I decided to have all the
.dialogchanges in the samematchinstead of splitting between the top and bottom matches.