Skip to content

feat: add confirmation for resetting panel settings#1983

Open
Zij-IT wants to merge 1 commit into
pop-os:masterfrom
Zij-IT:master
Open

feat: add confirmation for resetting panel settings#1983
Zij-IT wants to merge 1 commit into
pop-os:masterfrom
Zij-IT:master

Conversation

@Zij-IT
Copy link
Copy Markdown

@Zij-IT Zij-IT commented Apr 26, 2026

I accidentally reset my settings, and was surprised by the lack of a confirmation for the action. This PR would address #1967. I made the assumption that this being moved from libcosmic to cosmic-settings was an indication that this is something that was worth a PR.

This PR adds a confirmation dialog for panel settings after clicking on "Reset to default". The solution is based on the dialog found in the WiFi (pages/networking/wifi.rs).

This only implements the fix for the panel-settings. AFAICT this could also be applied to wallpaper, appearance and shortcuts, which all three use a simple "Reset to default" without confirmation. If this gets accepted, and a similar implementation is desired for the other locations, just let me know.

P.S.: I ran just check in cosmic-settings which resulted in about 252 unrelated warnings.

Edit: Force push was because I decided to have all the .dialog changes in the same match instead of splitting between the top and bottom matches.


  • I have disclosed use of any AI generated code in my commit messages.
    • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
    • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.

@Zij-IT Zij-IT force-pushed the master branch 2 times, most recently from a51fcb4 to bae9977 Compare April 26, 2026 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant