Open
Conversation
Author
|
I'm just checking in on this PR. It's been open for over a month and I want to make sure someone takes a look at it. I really do think that it is a unique feature that others, including me, would enjoy having. It does not change the default behavior of the terminal, this is an optional enhancement feature. |
Member
|
We are open to it. This amount of new UI would not be able to land during the first release cycle (we are entering feature freeze and focusing on bug fixes now). |
Author
Awesome to hear! Wish I'd have gotten this in a little earlier, lol! I'll keep the branch sync'd with upstream so it'll be easier to integrate later. |
Author
|
@jackpot51 and @mmstick just wanted to see if this is still a viable addition? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for customizable profile layouts and includes a minor change to the terminal's default behavior. The most important changes involve adding new structures for defining layouts, updating the
Profilestruct to include an optional layout configuration, and modifying the terminal's default focus state.Support for customizable profile layouts:
src/config.rs: AddedLayoutDefinitionandSplitDefinitionstructs to define profile layouts, including properties for split axis, ratio, and target pane. Also introduced theSplitAxisenum to specify horizontal or vertical splits.src/config.rs: Updated theProfilestruct to include an optionalcustom_layoutfield of typeOption<LayoutDefinition>. This allows profiles to define custom layouts.src/config.rs: Modified theDefaultimplementation forProfileto setcustom_layouttoNoneby default.Terminal behavior change:
src/terminal.rs: Changed the default value ofis_focusedin theTerminalstruct tofalseinstead oftrue.Localization:
i18n/en/cosmic_term.ftl: Added a new localization stringprofile-layouts = Profile Layoutsto support the new feature.