Skip to content

Add Ayu Dark, Ayu Mirage, and Ayu Light color schemes#775

Open
diegoserranor wants to merge 2 commits into
pop-os:masterfrom
diegoserranor:ayu-color-schemes
Open

Add Ayu Dark, Ayu Mirage, and Ayu Light color schemes#775
diegoserranor wants to merge 2 commits into
pop-os:masterfrom
diegoserranor:ayu-color-schemes

Conversation

@diegoserranor
Copy link
Copy Markdown

Based on https://ayutheme.com/

Disclaimer

  • I have disclosed use of any AI generated code in my commit messages.
    • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
    • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.

@bri-tong
Copy link
Copy Markdown

bri-tong commented Apr 1, 2026

Code Review — Add Ayu Dark, Ayu Mirage, and Ayu Light color schemes

Summary

Clean, purely additive PR that introduces three new Ayu color scheme .ron files. The files follow the established format exactly, all hex color values are valid 6-digit codes, and no source code changes are required since color schemes in the color-schemes/ directory are standalone data files. No blocking issues found.

Blocking Issues

None.

Non-blocking Suggestions

  1. dim colors are identical to normal in all three schemes. This is a pre-existing pattern shared with Dracula, Github Dark, and the Modus variants, so it's consistent with this repo's conventions. However, schemes like Gruvbox Dark, Solarized Dark, and Everforest Dark provide distinct muted dim colors which gives users a richer visual distinction for dim text. If the Ayu reference defines specific dim variants, it would be worth using those instead.

  2. Ayu Mirage bright palette is identical to normal for 6 of 8 colors (red, green, yellow, blue, magenta, cyan — only black and white differ). This means terminal applications that rely on bold/bright colors to distinguish from normal will have no visual difference for those 6 colors. If this matches the official Ayu Mirage spec, it's fine, but worth confirming it's intentional.

  3. Hex case convention: The new files use lowercase hex (#bfbdb6) which is fine — existing schemes are split between uppercase (Gruvbox, Solarized, COSMIC) and lowercase (Dracula, Seashells). No consistency requirement, just noting the mix.

Questions / Clarifications

  • Were the color values sourced directly from https://ayutheme.com/ or from another Ayu port (e.g., the Ayu VSCode extension, alacritty/ayu)? The bright colors for Ayu Dark differ from normal ones (good), but the bright colors for Ayu Mirage are almost entirely the same as normal — I'd like to confirm that's the intended mapping from the reference source.

@diegoserranor
Copy link
Copy Markdown
Author

Hi @bri-tong Thank you for code review and the feedback.

The color values were indeed based from the vscode theme in my first commit. However, I have adjusted these to be based on the npm package https://github.com/ayu-theme/ayu-colors. This package is recommended by https://ayutheme.com/ for building Ayu theme ports.

Regarding the dim values, I could not find these in the Ayu spec nor in the themes for vscode, alacritty nor ghostty. I defaulted to setting dim equal to normal values.

I'd be happy to experiment on a palette with an adjusted opacity for the dim values if desired.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants