feat: allow configuring terminal pane borders#778
Open
bgub wants to merge 1 commit into
Open
Conversation
|
@bgub what is the container color right now? |
Author
|
@maria-komarova do you mean the existing container? Or the container I added? |
|
@bgub which one is around the split area on the screenshot? |
bgub
force-pushed
the
pane-border-styles
branch
from
2272449 to
3c13e05
Compare
Author
|
@maria-komarova it's |
|
Awesome, thanks! It looks good on the screenshot. |
Author
|
@maria-komarova I almost wonder if it would look better with slightly skinnier borders... |
|
Those are gaps really, not borders. And I think it looks good this way. Otherwise we should just use dividers. |
Author
|
@maria-komarova fair enough! What are next steps then? Should I just wait on a review or do you want me to be actively rebasing on the base branch? |
wash2
approved these changes
Apr 15, 2026
Member
|
There are some conflicts on this now. Since it already has both approvals, it should be good to merge after those are resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volunteered for this in the Pop!_OS Mattermost! When there are 2+ split panes, I put a container behind the pane grid and add gaps between panes so the background shows through. I didn't address the active pane background color yet (tried it but it doesn't seem to integrate with terminal color themes yet). Screenshot below.