feat(font): add disable_ligatures toggle in advanced font settings#800
Open
HermeticOrmus wants to merge 1 commit into
Open
feat(font): add disable_ligatures toggle in advanced font settings#800HermeticOrmus wants to merge 1 commit into
HermeticOrmus wants to merge 1 commit into
Conversation
Adds Config.disable_ligatures (default: false). When enabled, disables the OpenType `liga`, `clig`, and `calt` features on the terminal's default font attrs. Toggle wired into View > Settings > Font > Advanced font settings, propagates live to existing terminals via set_config. Refs: pop-os#735
Member
|
The PR template is mandatory |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #735.
Adds
Config.disable_ligatures(default:false). When enabled, disables the OpenTypeliga,clig, andcaltfeatures on the terminal's default font attrs.The toggle is exposed in View > Settings > Font > Advanced font settings, alongside the existing
Make bold text brightertoggle, matching the location requested in the issue.Changes propagate live to existing terminals through
Terminal::set_config, so toggling does not require restarting tabs.Files
i18n/en/cosmic_term.ftl—disable-ligatures = Disable ligaturessrc/config.rs—disable_ligatures: boolfield,#[serde(default)]src/main.rs—Message::DisableLigatures, settings row, update handlersrc/terminal.rs—no_ligature_features()helper, applied innewand on live config changeVerification
cargo checkpassesfalse