Fix fractional wheel scrolling in scrollback and alternate screen#811
Open
jerezereh wants to merge 3 commits into
Open
Fix fractional wheel scrolling in scrollback and alternate screen#811jerezereh wants to merge 3 commits into
jerezereh wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issues #781 (commit 30738db) and #385 (commit 0468347).
Wheel scrolling previously cast float inputs to ints, dropping all fractional scrolling that occurs on most modern, high-resolution scroll wheels. Commit 30738db addresses this by keeping scroll delta as float, and saving remainders to state.
Additionally noticed while testing that scroll events were not received in ALT_SCREEN mode (
less,vi,man, etc.). Fixes in commit 0468347 address this by allowing non-SGR mouse mode wheel events, sending mouse wheel or arrow key events depending on TermMode::APP_CURSOR, and saving the fractional mouse wheel events (as in the previous commit).Tests have been added to both
terminal_box.rsandmouse_reporter.rs.Disclaimer: As I am new to Rust, AI agent Codex was used for reference and to review code. If any changes here don't look right, I would be happy to receive feedback or guidance.