Skip to content

chore: support more named keys for keyboard shortcuts#823

Merged
mmstick merged 1 commit into
pop-os:masterfrom
hojjatabdollahi:hojjat/keyboard-shortcut
May 28, 2026
Merged

chore: support more named keys for keyboard shortcuts#823
mmstick merged 1 commit into
pop-os:masterfrom
hojjatabdollahi:hojjat/keyboard-shortcut

Conversation

@hojjatabdollahi
Copy link
Copy Markdown
Contributor

@hojjatabdollahi hojjatabdollahi commented May 23, 2026

I set Ctrl+Shift+Enter to open a new window, but pressing it would just type a new line in the terminal. Turns out "Enter" was missing. I added a couple of more Named keys.

Fixes #808


  • I have disclosed use of any AI generated code in my commit messages.
    • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.s too frequently and I searched it I couldn't find a solution
    • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.

@jackpot51 jackpot51 requested a review from a team May 23, 2026 11:51
@hojjatabdollahi
Copy link
Copy Markdown
Contributor Author

Can this be merged please? I wanna rebase my other fixes.

@mmstick mmstick merged commit 3d8ca65 into pop-os:master May 28, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

some keybindings registered in the settings interface but can't trigger action

4 participants