Fix scrolling in lazygit, less, htop#826
Merged
Merged
Conversation
909b40b to
fe14af2
Compare
jackpot51
approved these changes
May 28, 2026
jklgrasso
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes scrolling in lazygit, less, htop, man...
If you open lazygit and try to scroll the code changes using a high res mouse (e.g. MX Master 3S). It does not scroll unless you scroll super fast. It's because the scroll even comes in and since the amount is less than a line, it gets rounded down to 0, instead getting accumulated.
The issue with
lesswas that we always were sending normal-mode sequenceb"\x1B[A", butlesssets application cursor mode and expectsb"\x1bOA".I had to move
report_mouse_wheel_as_arrowsto theterminal.rsto keep Rust happy since we need mutable access to the terminal and the terminal's mouse_reporter.