Extract color overrides from attrs_list into new color_spans field#101
Draft
geieredgar wants to merge 2 commits intopop-os:mainfrom
Draft
Extract color overrides from attrs_list into new color_spans field#101geieredgar wants to merge 2 commits intopop-os:mainfrom
attrs_list into new color_spans field#101geieredgar wants to merge 2 commits intopop-os:mainfrom
Conversation
geieredgar
force-pushed
the
draw-attrs
branch
2 times, most recently
from
849f891 to
1fd65e6
Compare
Contributor
|
this looks very promising, However You probably should move Metadata in with the Color as these are ones that don't affect the Layout. |
Contributor
|
Might also be Worth it to allow the End user to get a Mutable Span if one Already Existed so they can update it rather than replace it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up for #100. It removes the
color_optfield fromAttrsand stores the information in the newcolor_spansfield ofBufferLineinstead. This allows it to be mutated without having to do relayouts.Fixes #69.