subsurface_widget: Handle viewport and set source rectangle
#227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test scrolling. Single color buffers in `sctk_subsurface` aren't good for comparing it, and `sctk_subsurface_gst` isn't working on latest gst with explicit sync (and AppSync isn't accepting the dmabuf when I try to modify it.)
This is needed to crop subsurface when needed, instead of rendering overlapping other things. And to offset while scrolling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scrolling seems to be more or less working... but it doesn't seem to be triggering redraws properly, and scrolling is throttled to 1 fps.
Also the
scrollabledoesn't seem to subtract the scrollbar from the size allocated to its child (this is true of upstream iced). But due to how subsurfaces work, it ends up above the scroll bar instead of the scroll bar drawing above it.